This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
gcs: fix wrong path of gcs prefix #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinChenn
reviewed
Dec 14, 2020
pkg/storage/gcs.go
Outdated
| @@ -84,9 +85,16 @@ type gcsStorage struct { | |||
| bucket *storage.BucketHandle | |||
| } | |||
|
|
|||
| func (s *gcsStorage) objectName(name string) string { | |||
| if strings.HasSuffix(s.gcs.Prefix, "/") { | |||
| return s.gcs.Prefix + name | |||
There was a problem hiding this comment.
Maybe path.join(s.gcs.Prefix ,name) is better.
|
LGTM |
ti-srebot
approved these changes
Dec 14, 2020
|
/run-integration-test |
|
please also move this to apply to all storage types Line 61 in da9f975 |
ti-srebot
added
status/LGT3
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Dec 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #648 |
3pointer
added a commit
that referenced
this pull request
Dec 14, 2020
This was referenced Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
backup meta file out of backup directory in gcs storage.
What is changed and how it works?
ensure gcs prefix endwith "/"
Check List
Tests
before:
after:
Related changes
Release Note