Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

checksum: fix SEGFAULT during backup #455

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Fix SEGFAULT during backup, close #450 .

What is changed and how it works?

Do not pass a nil pointer to distsql.Checksum.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Fix the issue that checksum could SEGFAULT during backup.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added the type/bug Something isn't working label Aug 11, 2020
@overvenus overvenus requested review from 3pointer and kennytm August 11, 2020 08:09
Copy link
Collaborator

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 11, 2020
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Aug 11, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Aug 11, 2020
@kennytm
Copy link
Collaborator

kennytm commented Aug 11, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@overvenus merge failed.

@overvenus
Copy link
Member Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b36c351 into pingcap:master Aug 11, 2020
@overvenus overvenus deleted the fix-checksum-segfault branch August 11, 2020 09:03
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #479

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksum SEGFAULT when backuping datas
5 participants