Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

cherry-pick #279 to release 4.0 #284

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

3pointer
Copy link
Collaborator

What problem does this PR solve?

update tidb-tools to solve table name changing after applyOn black-white-list, details at pingcap/tidb-tools#342

What is changed and how it works?

change tidb-tools to latest version

Check List

Tests

  • No code

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@kennytm
Copy link
Collaborator

kennytm commented May 14, 2020

/run-integration-test

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #284 into release-4.0 will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0     #284      +/-   ##
===============================================
- Coverage        71.60%   71.40%   -0.21%     
===============================================
  Files               48       48              
  Lines             4994     5000       +6     
===============================================
- Hits              3576     3570       -6     
- Misses             960      970      +10     
- Partials           458      460       +2     
Impacted Files Coverage Δ
pkg/restore/import.go 66.66% <0.00%> (-4.02%) ⬇️
pkg/summary/collector.go 88.23% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2630836...7f5c4e7. Read the comment docs.

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGTM1 label May 14, 2020
@kennytm kennytm added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels May 14, 2020
@kennytm kennytm merged commit 6f1ea23 into pingcap:release-4.0 May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants