-
Notifications
You must be signed in to change notification settings - Fork 102
tests: fix br_tikv_outage learner bug #1256
tests: fix br_tikv_outage learner bug #1256
Conversation
/run-integration-test |
/run-integration-test |
6 similar comments
/run-integration-test |
/run-integration-test |
/run-integration-test |
/run-integration-test |
/run-integration-test |
/run-integration-test |
@YuJuncen PTAL |
…nto fix_tikv_outage_learner_bug
/run-integration-test |
Co-authored-by: kennytm <kennytm@gmail.com>
This sounds weird to me, I remember the scripts will recover the cluster to normal state before run each case, thus cases won't have side effect for each other. Are we sure this is the root cause? This case had already been fixed for several times 😭, is this the last time |
This test has many bugs which all can make test failed, And I think this is the last bug. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0ce3aa1
|
In response to a cherrypick label: new pull request created: #1281. |
In response to a cherrypick label: new pull request created: #1282. |
In response to a cherrypick label: new pull request created: #1283. |
What problem does this PR solve?
fix issue #1050
In the case
outage-after-request
, there is a voter peer on tikv1 removed, and then a learner peer on tikv1 added.But then quickly in the next case
outage-at-finegrained
(don't restart tikv while doing backup), tikv3 is killed.So there is only 1 peer and 1 learner for region 257, lead to test got stuck.
What is changed and how it works?
It seems the case
outage-after-request
have a bad influence on the next case, so this PR try to exchange the sequence of these cases.Check List
Related changes
Release note
-No release note