Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix id allocator base for double auto_increment field (#1178) #1185

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1178

What problem does this PR solve?

Fix the bug that lightning will got invalid auto_increment base if the corresponding auto_increment field is double/float.

[2021/06/05 13:37:03.227 +08:00] [INFO] [tidb.go:355] ["alter table auto_increment start"] [table=`db`.`table`] [auto_increment=4753151844738400257]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

  • Fix the bug that lightning rebase wrong auto_increment base when the auto_increment field type is float or double.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kv/kv.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 24, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 28, 2021
@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0f065d7

@ti-chi-bot ti-chi-bot merged commit 0d9fae5 into pingcap:release-4.0 Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants