Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

tests/br: fix bug in issue #1158 #1160

Merged
merged 3 commits into from
Jun 2, 2021
Merged

tests/br: fix bug in issue #1158 #1160

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa7eae2
ensure tikv start up completely before restore
Leavrth May 31, 2021
80ca77c
use ensure_tikv instead
Leavrth Jun 1, 2021
0c47e51
add ensure_tikv into kv_outage
Leavrth Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/br_tikv_outage/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ github.com/pingcap/br/pkg/conn/hint-get-backup-client=1*return(\"$hint_get_backu
backup_pid=$!
single_point_fault $failure
wait $backup_pid
# let tikv start up completely if backup is finished before tikv restarts
ensure_tikv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we move this line into the case block to make it clearer which failures depend on this

Copy link
Collaborator Author

@Leavrth Leavrth Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add the line into kv_outage function where tikv restart. It seems better.

case $failure in
scale-out | shutdown | outage-at-finegrained ) stop_services
start_services ;;
Expand Down