Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

log: delete lightning's redact package (#1003) #1044

Merged
merged 7 commits into from
Jun 1, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 21, 2021

cherry-pick #1003 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/1044

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/1044:release-5.0-921e0da638d8

What problem does this PR solve?

lightning and br's redact package are duplicated.

What is changed and how it works?

replace lightning's redact package with br's.

Check List

Tests

  • Unit test
  • Integration test

Release Note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@lichunzhu
Copy link
Contributor

/cherry-pick-invite

@ti-srebot
Copy link
Contributor Author

@lichunzhu please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/br/invitations

@glorv
Copy link
Collaborator

glorv commented Apr 21, 2021

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented Apr 21, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 21, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@lichunzhu: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 21, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 413be51

@glorv
Copy link
Collaborator

glorv commented Apr 21, 2021

/build

@lichunzhu
Copy link
Contributor

/merge

@lonng lonng added this to the v5.0.2 milestone May 27, 2021
@lichunzhu
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kennytm
Copy link
Collaborator

kennytm commented Jun 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c30bea8

@ti-chi-bot ti-chi-bot merged commit ecfaf2e into pingcap:release-5.0 Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants