lightning: Return error for empty path (#1397)

.gitignore

@@ -11,3 +11,4 @@
 # for the web interface
 web/node_modules/
 web/dist/
+.vscode/

pkg/lightning/restore/restore.go

@@ -513,6 +513,8 @@ func (worker *restoreSchemaWorker) makeJobs(
 				// we already has this table in TiDB.
 				// we should skip ddl job and let SchemaValid check.
 				continue
+			} else if tblMeta.SchemaFile.FileMeta.Path == "" {
+				return errors.Errorf("table `%s`.`%s` schema not found", dbMeta.Name, tblMeta.Name)
 			}
 			sql, err := tblMeta.GetSchema(worker.ctx, worker.store)
 			if sql != "" {

pkg/lightning/restore/restore_test.go

@@ -1526,6 +1526,33 @@ func (s *restoreSchemaSuite) TestRestoreSchemaFailed(c *C) {
 	c.Assert(errors.ErrorEqual(err, injectErr), IsTrue)
 }
 
+// When restoring a CSV with `-no-schema` and the target table doesn't exist
+// then we can't restore the schema as the `Path` is empty. This is to make
+// sure this results in the correct error.
+// https://github.com/pingcap/br/issues/1394
+func (s *restoreSchemaSuite) TestNoSchemaPath(c *C) {
+	fakeTable := mydump.MDTableMeta{
+		DB:   "fakedb",
+		Name: "fake1",
+		SchemaFile: mydump.FileInfo{
+			TableName: filter.Table{
+				Schema: "fakedb",
+				Name:   "fake1",
+			},
+			FileMeta: mydump.SourceFileMeta{
+				Path: "",
+			},
+		},
+		DataFiles: []mydump.FileInfo{},
+		TotalSize: 0,
+	}
+	s.rc.dbMetas[0].Tables = append(s.rc.dbMetas[0].Tables, &fakeTable)
+	err := s.rc.restoreSchema(s.ctx)
+	c.Assert(err, NotNil)
+	c.Assert(err, ErrorMatches, `table .* schema not found`)
+	s.rc.dbMetas[0].Tables = s.rc.dbMetas[0].Tables[:len(s.rc.dbMetas[0].Tables)-1]
+}
+
 func (s *restoreSchemaSuite) TestRestoreSchemaContextCancel(c *C) {
 	childCtx, cancel := context.WithCancel(s.ctx)
 	mockSession := mock.NewMockSession(s.controller)