Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Build and Publish Docker Image #242

Merged
merged 30 commits into from
Jan 14, 2024
Merged

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Jan 3, 2024

Purpose

The purpose is to publish docker images on each merge to main and each release.

Solution

Added a new workflow file that builds and pushes the image to GitHub packages.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@izellevy all in all LGTM.
See two small comments

.github/workflows/build-push-image.yml Show resolved Hide resolved
.github/workflows/build-push-image.yml Show resolved Hide resolved
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@izellevy we need to think how are we going to add tests for this pipeline

@igiloh-pinecone igiloh-pinecone merged commit 6c2272f into main Jan 14, 2024
10 checks passed
@igiloh-pinecone igiloh-pinecone deleted the feature/automatic_builds branch January 14, 2024 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants