Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemovedInDjango18Warning #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix RemovedInDjango18Warning #12

wants to merge 1 commit into from

Conversation

naringas
Copy link

@naringas naringas commented Aug 6, 2015

RemovedInDjango18Warning: LogicalDeleteModelAdmin.querysetmethod should be renamedget_queryset.

django.contrib.admin.ModelAdmin.get_queryset

```RemovedInDjango18Warning: `LogicalDeleteModelAdmin.queryset` method should be renamed `get_queryset`.```
@psychok7
Copy link
Contributor

psychok7 commented Aug 8, 2015

@naringas instead of renaming the function why not adding it as a new function to keep backward compatibility??

If i am not mistaken if you rename this you will be breaking previous django versions

@naringas
Copy link
Author

get_queryset is supported from django 1.6 (so this change will break django 1.5), however not having this change will break django 1.8

so, add this @psychok7?

def queryset(self, request):
    return self.get_queryset(self, request)

@jtauber
Copy link
Member

jtauber commented Aug 10, 2015

breaking 1.5 is fine I think

@psychok7
Copy link
Contributor

@naringas exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants