Refactor code for displaying track lists. #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the start of an effort to consolidate how lists of tracks are retrieved and displayed in the UI:
renderSongLi
. There's more work to be done here as the variousplay...
functions can also probably be refactored and consolidated. I'd eventually like to get to a point where we only have one list of tracks that can be cached and used in all of the panes. But that is a PR for another day.local
orfile
extensions will now also render album and artist details, which fixes Track artist is not displayed in browse results #99. It works well but the performance impact is noticeable for lists containing more than a hundred tracks or so. We might eventually either make this a configuration setting, or include a button on-screen that the user can use to toggle the details for anyTrackRefs
. Ultimately, this could also be used to sort by artist or album on the fly.The rules for displaying album details are currently as follows:
This PR also paves the way for fixing #69 and #96.