Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better TOML libs -> tomlkit for style, tomli(-w) for speed #496

Open
4 of 7 tasks
goodboy opened this issue Mar 24, 2023 · 3 comments
Open
4 of 7 tasks

Better TOML libs -> tomlkit for style, tomli(-w) for speed #496

goodboy opened this issue Mar 24, 2023 · 3 comments
Labels
accounting prolly positioning: the accounting of "what/when (is) owned" clearing auction and mm tech: EMS, OMS, algo-trading config ledger trade, accounts and other user focal event history tracking, management and storage perf efficiency and latency optimization

Comments

@goodboy
Copy link
Contributor

goodboy commented Mar 24, 2023

Since we already had to roll our own based on writing a particular
styled .clears table to the pps.toml file, this is a task to
choose the best (combo of) lib(s).

Here's the verbatim bullet-task breakout from #345:


Turns out there's been a bunch of project updates in the space 🙏🏼,

@goodboy goodboy added perf efficiency and latency optimization clearing auction and mm tech: EMS, OMS, algo-trading config ledger trade, accounts and other user focal event history tracking, management and storage accounting prolly positioning: the accounting of "what/when (is) owned" labels Mar 24, 2023
@goodboy
Copy link
Contributor Author

goodboy commented Apr 29, 2023

personal todo: Need to link our PR for inline array comment config support and possibly open an issue to support passing through such inputs to .item.array()

@goodboy
Copy link
Contributor Author

goodboy commented May 13, 2023

goodboy added a commit that referenced this issue May 17, 2023
We still need to get some patches landed in order to resolve:
- python-poetry/tomlkit#288
- python-poetry/tomlkit#289
- python-poetry/tomlkit#290

But, this does work for style preservation and the inline-table style we
were previously hacking into the `toml` lib in `.accounting._toml`,
which we can pretty much just drop now B)

Relates to #496 (pretty much solves it near-term i think?)
goodboy added a commit that referenced this issue May 17, 2023
We moved to `tomlkit` as per #496 and this lets us drop the mess that
was the inline-table encoder in `.accounting._toml` XD

Relates to #496
@goodboy goodboy changed the title Better TOML lib Better TOML libs -> tomlkit for style, tomli(-w) for speed May 25, 2023
@goodboy
Copy link
Contributor Author

goodboy commented Jun 19, 2023

Heh, i actually was on the side of this issue / request submitted to the spec:
toml-lang/toml#516

After reading it though, i don't think multi-line tables really are that necessary.

Interested in what others think though as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounting prolly positioning: the accounting of "what/when (is) owned" clearing auction and mm tech: EMS, OMS, algo-trading config ledger trade, accounts and other user focal event history tracking, management and storage perf efficiency and latency optimization
Projects
None yet
Development

No branches or pull requests

1 participant