review map plotting #217
Merged
review map plotting #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove old `MapPlots` - rename `CartopyPlots` -> `MapPlot` - clean up for most basic functionality - adapt `ClimateNetworks.ipynb` accordingly - add most basic test in `test_map_plot.py` - remove respective TODOs in init-files - adapt docs
5 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 60.82% 62.82% +2.00%
==========================================
Files 44 43 -1
Lines 6356 6220 -136
==========================================
+ Hits 3866 3908 +42
+ Misses 2490 2312 -178 ☔ View full report in Codecov by Sentry. |
|
@fkuehlein, please kindly check my minor edits above. Otherwise, this should be good to go. |
|
Thank you for those additions, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed it to
MapPlotbecause you can now only plot a single dimension at a time. Of course this can be extended by the user. SeeClimateNetwork.ipynbtutorial for example usage.