Cleanup #310
Cleanup #310
Conversation
| if game['phase'] == 'FINAL' or game['phase'] == 'FINAL_OVERTIME': | ||
| # show game duration only if user wants to see it | ||
| if addon.getSetting('hide_game_length') == 'false': | ||
| game_info = '%s [CR] Duration: %s' % (game['phase'], str(datetime.timedelta(seconds=int(float(game['video']['videoDuration']))))) |
There was a problem hiding this comment.
Just noting, in case the issue comes back to bite us: there were a lot of oddities with datetime and Kodi on some platforms. We'll just keep this change in mind if we get bug reports and need to put the "try" statement back in.
---Alex
| isBlackedOut = 'false' | ||
| listitem.setProperty('video_id', video_id) | ||
| listitem.setProperty('game_versions', 'Live') | ||
| else: # ONDEMAND |
There was a problem hiding this comment.
I'm not familiar with this status. What is "on demand"?
There was a problem hiding this comment.
Basically, all games that are archived has the 'videoStatus' set to 'ONDEMAND'. There's probably some additional info we're going to need in regards to blacked out games etc, but this should be easy to add later on.
There was a problem hiding this comment.
@emilsvennesson Ahh, good to know. Thanks for the explanation.
---Alex
|
@emilsvennesson Really great stuff. Thanks a lot for these changes. Makes a bunch of code much more readable. ---Alex |
|
@aqw I'm happy to help out! :-) |
#294