use focus and snap hardware buttons #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgibbon
force-pushed
the
shutter-buttons
branch
from
0e9037f to
e411302
Compare
jgibbon
force-pushed
the
shutter-buttons
branch
from
e411302 to
26ade0d
Compare
|
FYI, just rebased on the white space changes in the fix-manual branch. edit: this whole upstream rebasing/force pushing for the sake of fewer visible commits makes me a bit uncomfortable, but as a guest here I'll just abide by the rules. ;) |
|
Some more Info to simplify testing:
cheers! |
|
Works for me. |
mlehtima
reviewed
Oct 1, 2019
qml/pages/CameraUI.qml
Outdated
| @@ -555,6 +538,35 @@ Page { | |||
| } | |||
| } | |||
|
|
|||
| Keys.onPressed: { | |||
| if(event.isAutoRepeat) { | |||
There was a problem hiding this comment.
For consistent style add space between if and (
|
Maybe also add [some_tag] to beginning of commit message, check the commit history for examples. |
jgibbon
force-pushed
the
shutter-buttons
branch
2 times, most recently
from
1cf8815 to
64cbdfb
Compare
jgibbon
force-pushed
the
shutter-buttons
branch
from
64cbdfb to
9d40646
Compare
|
Changes:
I checked in with @piggz – I'll make the "===" changes as a different PR to get to test that without hurry and still getting a new release ready soon. I'll create an issue to remember. cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #57 with the much better solution you basically provided yourself.
cheers!