This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
utils: rename readInt32LE to readUInt32LE for clarity #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is actually performing an unsigned int32 read, as seen in the comment on the first line.
|
I dont really remember why I had to define this method. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
utils.readInt32LEtoutils.readUInt32LEfor clarity, as that is actually performing an unsigned int32 read, as seen in the comment on the first line of the impl.This is mostly a code style change that shouldn't affect the behavior.
See #65 for an actual bug fix (which was caused by an int/uint mixup).
On a side note: I am not exactly sure what do you mean by «as the Buffer ones from node and browserify are incompatible» and suppose that it might have been just another int/uint mixup here.
But I didn't touch that to be on the safe side.
Perhaps a better way would be to remove that method whatsoever and just use
buffer.readUInt32LE.Thoughts?