Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requests instead of urllib behind six #29

Merged
merged 1 commit into from
Aug 12, 2018
Merged

Conversation

job
Copy link
Contributor

@job job commented Jun 4, 2018

requests is the superior library for handling downloads

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 72.896% when pulling bef9248 on job:requests into d426d38 on pierky:master.

@job
Copy link
Contributor Author

job commented Jun 4, 2018

This also addresses the issue where the RIPE NCC RPKI Validator v3 expects accept: text/json as HTTP header. RIPE-NCC/rpki-validator-3#37

@job
Copy link
Contributor Author

job commented Aug 7, 2018

@pierky can you please merge this

@pierky
Copy link
Owner

pierky commented Aug 7, 2018

@job I already merged it in the dev branch, along with other code (Registro.BR included).
CI tests (which also include tests for Registro.br on BIRD) worked well, I need to test the new feature on the OpenBGPD side: do you have a chance to test it?
The pre-release is out: v0.19.0-alpha1 (v0.19.0-alpha2 only fixes CD installation tests)

@pierky pierky merged commit bef9248 into pierky:master Aug 12, 2018
pierky added a commit that referenced this pull request Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants