Create a PID for LilyGO T-Display rp2040 #827
Conversation
See pull request pidcodes/pidcodes.github.com#827 The original values from @erongd in https://github.com/erongd/circuitpython/blob/lilygo_t_display_rp2040/ports/raspberrypi/boards/lilygo_t_display_rp2040/mpconfigboard.mk point to a T-Display with esp32 (VID 0x303A is for espressif) but this board uses a raspberry pico (VID 0x2E8A) but it has not been granted for this product a PID. The pid.codes is a workaround
1209/2023/index.md
Outdated
| --- | ||
| layout: pid | ||
| title: T-Display rp2040 | ||
| owner: LilyGO |
There was a problem hiding this comment.
Mind having yourself as the owner and link to the fork of CircuitPython with the changes? I want it to be clear that this isn't for LilyGo. It is for a third party using their hardware. Thanks!
There was a problem hiding this comment.
@tannewt sure, no problem. Yet I have a lot of options and possible answers, maybe you can point to the best one. Following the instructions on https://pid.codes/howto/ I have
2. Set up your organization page
a) I keep org/LilyGO/index.md
b) I create a new page for myself as org/kreier/index.md , linking to https://kreier.org
c) I create one for our school club org/SSISRobotics/index.md and link to https://github.com/ssis-robotics
3. Find a VID and PID - 1209/2023/index.md
a) Keep the title in 1209/2023/index.md
b) Change title to 'SSIS:bit with T-Display rp2040' in reference to my older project https://github.com/ssisbit/ssis.bit
c) Change the owner to Matthias Kreier
d) Change the site to adafruit/circuitpython#6037
e) Keep the source with https://github.com/Xinyuan-LilyGO/LILYGO-T-display-RP2040
f) Change the source to https://github.com/kreier/t-display where I collect ideas since 2020
g) Change the title to 'SSIS.bit with T-Display rp2040' and reference https://github.com/ssis-robotics/ssis.bit
There was a problem hiding this comment.
@tannewt sure, no problem. Yet I have a lot of options and possible answers, maybe you can point to the best one. Following the instructions on https://pid.codes/howto/ I have
2. Set up your organization page
a) I keep org/LilyGO/index.md b) I create a new page for myself as org/kreier/index.md , linking to https://kreier.org c) I create one for our school club org/SSISRobotics/index.md and link to https://github.com/ssis-robotics
b or c is fine. Whichever you'd like.
3. Find a VID and PID - 1209/2023/index.md
a) Keep the title in 1209/2023/index.md b) Change title to 'SSIS:bit with T-Display rp2040' in reference to my older project https://github.com/ssisbit/ssis.bit c) Change the owner to Matthias Kreier d) Change the site to adafruit/circuitpython#6037 e) Keep the source with https://github.com/Xinyuan-LilyGO/LILYGO-T-display-RP2040 f) Change the source to https://github.com/kreier/t-display where I collect ideas since 2020 g) Change the title to 'SSIS.bit with T-Display rp2040' and reference https://github.com/ssis-robotics/ssis.bit
The title can be the same but I'd switch the site to the CP PR. Please change the owner to match 2.
My main goal is to not give the impression that the manufacturer of the closed source board was granted a PID.
There was a problem hiding this comment.
@tannewt Thanks for the feedback, that's a good solution to make a proper use of the pidcodes project. I updated both the organization description (LilyGO is out and a new SSIS-Robotics in) and the 1209/2023/index.md. I left the title as T-Display rp2040 since the organization name will be prefixed in the final list.
There was a problem hiding this comment.
BTW: Thanks for volunteering to run this project. Please don't burn out. 🙂
There was a problem hiding this comment.
@kreier First of all thanks for get this through. Do you mind if I add a PID request for the T-Display PICOC3 board under your org "SSS Robotics" just like the T-Display RP2040 so I can try to contribute the board definition to CircuitPython as well. That board has wifi build-in should be able to power some very interesting project. Or if you have other suggestion for obtain a official PID?
There was a problem hiding this comment.
Hi @erongd , sure, no problem. You can copy the SSIS Robotics information for another PID request. Let's see if that is necessary. I think you should be able to use the same PID for the PicoC3 (depending how you plug in the USB-C cable) since in one side it's a regular T-Display rp2040 (only 2 serial pins connected to another onboard MCU) and the other way it is covered by Espressif - and not relevant for us, since we won't use it for CircuitPython on the ESP32 C3.
|
@kreier Thanks for taking this up. Hope you can make the changes requested and we can get support for this device soon! |
This will be used for our ssis.bit based on the T-Display with rp2040 for our Advanced Automation class. - https://github.com/ssis-robotics/ssis.bit - https://github.com/ssis-aa/rvr2023
As LilyGO does not have their own VID for their boards and the application for a PID with the 0x2E8A VID has not been successful for a year this was the suggested solution by @tannewt already in November 16th, 2022 (adafruit/circuitpython#6037). I don't work for LilyGO, but as a teacher would like to use this board in education because of the integrated display and input buttons (current solution: https://github.com/ssis-aa/rvr2023).