0.5.7 #536
Merged
0.5.7 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
picturepan2
commented
Nov 25, 2018
picturepan2
commented
- Add pure CSS 360-Degree Viewer
- Improve Docs SEO
- Change Carousels image number to variable More than 4 images in Carousel #428
- Fix Form textarea height issue
houndci-bot
reviewed
Nov 25, 2018
|
|
||
| @for $s from 1 through ($image-number) { | ||
| .viewer-slider[value='#{$s}'] + .viewer-image { | ||
| background-position-y: percentage((($s)-1) * 1/(($image-number)-1)); |
There was a problem hiding this comment.
$image-number)-1 should be written with a single space on each side of the operator: $image-number) - 1$s)-1) * 1/(($image-number)-1) should be written with a single space on each side of the operator: $s)-1) * 1 /(( $image-number)-1$s)-1 should be written with a single space on each side of the operator: $s) - 1
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
|
|
| $image-width: 24rem; | ||
|
|
||
| .viewer-360 { | ||
| display: flex; |
There was a problem hiding this comment.
Properties should be ordered align-items, display, flex-direction
| @@ -0,0 +1,33 @@ | |||
| // 360 Degree Viewer | |||
| // The number of images | |||
| color: $gray-color-light; | ||
|
|
||
| @for $i from 1 through ($carousel-number) { | ||
| &:nth-of-type(#{$i}):checked ~ .carousel-nav .nav-item:nth-of-type(#{$i}) { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| opacity: 1; | ||
| z-index: $zindex-1; | ||
| @for $i from 1 through ($carousel-number) { | ||
| &:nth-of-type(#{$i}):checked ~ .carousel-container .carousel-item:nth-of-type(#{$i}) { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| z-index: $zindex-1; | ||
| } | ||
|
|
||
| %carousel-nav-checked { |
| // The number of carousel images | ||
| $carousel-number: 8; | ||
|
|
||
| %carousel-image-checked { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.