0.5.6 #534
0.5.6 #534
Conversation
picturepan2
commented
Nov 20, 2018
picturepan2
commented
- Add Docs Search No search engine in docs #509 Integrate algolia docsearch #291
- Add Copy icon
- Add Hero layout Something like hero in bulma #380
- Add multiline Tooltips ToolTip #500
- Replace transition: all; Never use 'transition: all' #526
- Fix Can't deactivate component /utilities/_position #511 issue
- Fix sidebar background height for short docs pages
The sidebar background did not cover the whole navigation when the page content was shorten than window height.
Fix sidebar background height for short docs pages
Add copy icon
| top: 60%; | ||
| width: .8em; | ||
| } | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
| left: 40%; | ||
| top: 35%; | ||
| width: .8em; | ||
| } |
There was a problem hiding this comment.
Rule declaration should be followed by an empty line
| .icon-copy { | ||
| &::before { | ||
| border: $icon-border-width solid currentColor; | ||
| border-radius: $border-radius; |
There was a problem hiding this comment.
Properties should be ordered border, border-bottom, border-radius, border-right, height, left, top, width
| @@ -7,5 +7,4 @@ | |||
| @import "mixins/position"; | |||
| @import "mixins/shadow"; | |||
| @import "mixins/text"; | |||
| @import "mixins/toast"; | |||
| @import "mixins/transition"; | |||
| @import "mixins/toast"; | |||
There was a problem hiding this comment.
Files should end with a trailing newline
| .hero-body { | ||
| padding: $layout-spacing; | ||
| } | ||
| } |
There was a problem hiding this comment.
Files should end with a trailing newline
| font-weight: 700; | ||
| text-align: left; | ||
| opacity: 0.5; | ||
| &:before { |
There was a problem hiding this comment.
Begin pseudo elements with double colons: ::
Rule declaration should be preceded by an empty line
Selector should have depth of applicability no greater than 2, but was 3
| font-size: .9em; | ||
| font-weight: 700; | ||
| text-align: left; | ||
| opacity: 0.5; |
There was a problem hiding this comment.
0.5 should be written without a leading zero as .5
| width: auto; | ||
| float: left; | ||
| padding: 0; | ||
| color: #02060c; |
There was a problem hiding this comment.
Color literals like #02060c should only be used in variable declarations; they should be referred to via variable everywhere else.
| @media (max-width: 768px) { | ||
| .algolia-autocomplete .algolia-docsearch-suggestion { | ||
| .algolia-docsearch-suggestion--subcategory-column { | ||
| display: inline-block; |
There was a problem hiding this comment.
Properties should be ordered color, display, float, font-size, font-weight, opacity, padding, text-align, width
|
|
||
| @media (max-width: 768px) { | ||
| .algolia-autocomplete .algolia-docsearch-suggestion { | ||
| .algolia-docsearch-suggestion--subcategory-column { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
