Update phpunit.yml with PHP 8.1 and 8.2 #616
Conversation
|
Out of curiosity do these changes mean support for PHP 7.2 and PHP 7.3 are being dropped? |
|
@DannyvdSluijs I do very little with this package, so it is not up to me. I think @stephangroen, @remkobrenters and probably you can better decide when to drop support for older versions. Stephan is out of the office right now and I saw a PR and some small things I could easily tweak. That is why I added 8.1 and 8.2 to test against. And I think it is a waste of energy to run to many tests, so I removed the oldest versions. If we want to drop support for PHP 7, we should update the |
|
I would suggest to allow legacy versions to be supported as long as they are not making things more complicated to maintain and do not block the implementation of new features. |
|
That is also my general take. But if there are some nice new features that are available in the oldest supported PHP version, then I am usually pretty easy with dropping old versions. That is what I do for packages that I am the main maintainer of, like https://github.com/picqer/php-barcode-generator. It is nice that it will not break older installations. Composer will just not update that installation further then the latest supported version. That makes it easier to drop support for versions that are already unsupported for 1-2 years. Versions 7.4 and 8.0 have some nice new features that can make this library better to read. So dropping all 7.x versions can make the interface better. |
|
Agree. @stephangroen as endboss of the project, what is your view on this? |
|
It's nice to keep allowing for legacy versions for a reasonable amount of time, but I'm a proponent of staying near the current versions. I'd hate for this package to be kept back because we support legacy versions for too long. It blocks progression. I get that it's not always easy with client work to be forced to upgrade though. PHP 7.x is already EOL for quite some time. PHP 8.0 is already on security fixes only. I'm for dropping support for PHP < 7.4. PHP 7.4 is then the latest legacy version we support for now. I'll update composer.json before merging. I'll wait a bit on input by @remkobrenters and long time contributor @DannyvdSluijs before merging this. |
|
Yeah agree. Keep support as long it is not in the way and when it gets in the way just drop support. |
|
In not having any strong feelings for keeping php 7.x support around. But I can imagine that it is helpful for some to still have 7.4 support in this package. Looking at the install statistics on packagist there install percentage of < 7.4 seems 3%. My questioning was purely to see if we can improve on type hints and other new constructs that are part of newer language versions. This would improve the experience for the 97% that are on newer versions. Which a can follow up after the proposed changes from Stephan. |
|
Released V4 with dropped 7.2 and 7.3 support. |
No description provided.