Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conditional title out of the list wrapper #343

Merged

Conversation

klemens-st
Copy link
Collaborator

CatListDisplayer::build_output should display the conditional
title before the list wrapper. This is already correctly
implemented in the default template file.

https://wordpress.org/support/topic/bug-h3-inside-ul-tag/

CatListDisplayer::build_output should display the conditional
title before the list wrapper. This is already correctly
implemented in the default template file.

https://wordpress.org/support/topic/bug-h3-inside-ul-tag/
@picandocodigo picandocodigo merged commit 9f2217d into picandocodigo:master Sep 19, 2018
@picandocodigo
Copy link
Owner

Good catch! I'll try to get some time to review the pending stuff this week. How do you feel about setting a milestone for a 1.0 release?

@klemens-st klemens-st deleted the fix-conditional-title branch September 19, 2018 10:23
@klemens-st
Copy link
Collaborator Author

Good idea! You have specific things in mind you'd like to include? I think my CatListDisplayer refactor plus deprecating CatListDisplayer::build_output and using a template instead would be nice (I have a branch with some initial work on it).

@picandocodigo
Copy link
Owner

Yeah, it would include at least all the current open PRs.

I initially had an idea for a GUI in the WordPress editor for a 1.0 release. It would open a modal with a form, you would select the LCP options you want, and this would write the shortcode automatically. But this proved to be quite complex so it would probably be an add-on plugin to LCP if I ever got to finish it.

So yeah, I'll try to review and merge the current PRs and try to find anything we would be missing for 1.0.

@klemens-st
Copy link
Collaborator Author

Funny you should say that. I started building a GUI months ago and continue when I have the time. I'll send it to you via email. I don't want it on Github yet because it's still a mess, in part because I am building it from a recommended plugin boilerplate...

@picandocodigo
Copy link
Owner

Hehe, that's awesome. I think I based my stuff on another plugin as well. But it's so old now there's probably nothing we can use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants