Parametrise bookmarks in pagination links #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,23 +37,26 @@ public function get_pagination($params){ | |||
| $this->next_page_num = null; | |||
| if ($pages_count > 1){ | |||
| for($i = 1; $i <= $pages_count; $i++){ | |||
| $lcp_paginator .= $this->lcp_page_link($i, $params['page'], $params['instance']); | |||
| $lcp_paginator .= $this->lcp_page_link($i, $params['page'], $params['instance'], | |||
| null, $params['bookmarks']); | |||
There was a problem hiding this comment.
Thanks @zymeth25! This is great as usual 👏
I was wondering if it would be ok to put char (or previous/next) as the last parameter of the lcp_page_link function to avoid passing in null. It looks like it would be fine, I tried it locally and it seems to be fine, tests pass and this file seems to be the only one using this function. What do you think? Do you mind if I add that change?
There was a problem hiding this comment.
Yeah, absolutely, that null doesn't look good in there. Just drop a short note in the changelog that this method has been refactored in case some users customized stuff in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination links are automatically appended with bookmarks to the list they are part of, i.e. lcp_instance. While this is desirable by many users, it can cause a real mess in many (badly written 😉 ) themes and plugins. So I'm proposing to introduce
pagination_bookmarksshortcode parameter. If present and set tonothe plugin won't append bookmarks to pagination URLs.Default (current) example link
http://example.org?lcp_page0=2#lcp_instance_0With
pagination_bookmarks=nohttp://example.org?lcp_page0=2Fixes #225, fixes #291
There were also many support questions on WP Forum, like this one or one from today