Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domains/regex tooltip on the sidebar numbers #3148

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 25, 2024

What does this implement/fix?

See title. As requested on Discourse.

image

Important

Needs FTL on the same branch tweak/api_regex_count pi-hole/FTL#2071


Related issue or feature (if applicable): https://discourse.pi-hole.net/t/show-number-of-domains-regex-on-the-left/72530

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip should contain "allowed" and "denied" in text form. This could be useful for screen readers.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER
Copy link
Member Author

DL6ER commented Sep 25, 2024

Screenshot from 2024-09-25 12-15-44

@DL6ER DL6ER merged commit 0a3dec5 into development Sep 25, 2024
11 checks passed
@DL6ER DL6ER deleted the tweak/api_regex_count branch September 25, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants