Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceAll() requires a global regex #2653

Merged
merged 1 commit into from
Jul 24, 2023
Merged

replaceAll() requires a global regex #2653

merged 1 commit into from
Jul 24, 2023

Conversation

PromoFaux
Copy link
Member

What does this implement/fix?

Currently, devel is broken. This is a regression from #2647.

This PR fixes #2650 (but for v5)

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Co-authored-by: DL6ER <DL6ER@users.noreply.github.com>
@PromoFaux PromoFaux requested a review from a team July 24, 2023 16:58
@PromoFaux PromoFaux merged commit b00d18b into devel Jul 24, 2023
13 checks passed
@PromoFaux PromoFaux deleted the fix/replaceAll-v5 branch July 24, 2023 17:28
@PromoFaux PromoFaux mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants