Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attenuate non-domain warning #2507

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Attenuate non-domain warning #2507

merged 2 commits into from
Jan 21, 2023

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Front-end change for pi-hole/pi-hole#5128

Renames "invalid domains" to "non-domains" and removed the red & bold text style.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team January 21, 2023 13:51
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Jan 21, 2023
@yubiuser
Copy link
Member Author

Removing the warning triangle could also be discussed.

Screenshot at 2023-01-21 14-52-13

Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux
Copy link
Member

Removing the warning triangle could also be discussed.

I think we should remove it for sure It does make the problem seem larger than it is - in that, it is not a problem at all for Pi-hole.

Maybe a tooltip/hint on the non-domains line that briefly explains what we mean by non-domains. Not sure

@PromoFaux PromoFaux closed this Jan 21, 2023
@PromoFaux PromoFaux reopened this Jan 21, 2023
@yubiuser
Copy link
Member Author

Triangle removed as well.

Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux
Copy link
Member

The numbers don't match up, but I suspect that's something in the core PR...

image

@PromoFaux
Copy link
Member

It was on the other PR

image

@yubiuser yubiuser merged commit ec7b753 into devel Jan 21, 2023
@yubiuser yubiuser deleted the tweak/unusable branch January 21, 2023 18:27
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-v5-18-2-and-core-v5-15-1-released/60695/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants