Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't link to github releases if docker tag is nightly or dev #2428

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Don't link to github releases if docker tag is nightly or dev #2428

merged 1 commit into from
Nov 11, 2022

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

This is entirely untested - but I think this is right!

Addresses #2426

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux linked an issue Nov 10, 2022 that may be closed by this pull request
Docker Tag nightly points to a non-existent URL #2426
Closed
@PromoFaux PromoFaux force-pushed the 2426-docker-tag-nightly-points-to-a-non-existent-url branch 2 times, most recently from 724e174 to e763ac6 Compare November 10, 2022 11:10
@PromoFaux
Copy link
Member Author

Been a while since I worked on this repo - are there any local commands to run to do the PHP linting?

@PromoFaux PromoFaux requested a review from a team November 10, 2022 13:31
@yubiuser
Copy link
Member

Needs a rebase.

@PromoFaux
Don't link to github releases if docker tag is nightly or dev
fad5b4f 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux force-pushed the 2426-docker-tag-nightly-points-to-a-non-existent-url branch from e763ac6 to fad5b4f Compare November 11, 2022 22:01
@PromoFaux PromoFaux merged commit 85ab573 into devel Nov 11, 2022
@PromoFaux PromoFaux deleted the 2426-docker-tag-nightly-points-to-a-non-existent-url branch November 11, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Tag nightly points to a non-existent URL
2 participants
@PromoFaux @yubiuser