Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery to v3.6.1. #2392

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Update jQuery to v3.6.1. #2392

merged 2 commits into from
Oct 28, 2022

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Updates jquery to the latest version 3.6.1. The release

does have some good bug fixes and improvements.

https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/ and https://blog.jquery.com/2022/08/26/jquery-3-6-1-maintenance-release/

There should be no breaking changes since 3.5.1., since the last big upgrade was to 3.5.0
https://jquery.com/upgrade-guide/3.5/

I used the jquery-migrate plugin (https://github.com/jquery/jquery-migrate) to detect changes. All warnings were of type jQuery.fn.XXX() event shorthand is deprecated. (See jquery/jquery#3214 and jquery/api.jquery.com#972

I fixed those for our files but left the vendor files untouched.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team October 10, 2022 14:08
@yubiuser yubiuser added Requires Testing PR: Approval Required Open Pull Request, needs approval labels Oct 10, 2022
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to test as careful as possible and nothing seems to break with this PR. It deserves entering the broader testing things get when in devel

@DL6ER DL6ER merged commit 6367d99 into devel Oct 28, 2022
@DL6ER DL6ER deleted the jquery branch October 28, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval Requires Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants