Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants in place of class constants #2342

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Fix #2340
Avoid the PHP Parse error when running a version < PHP 7.1.

How does this PR accomplish the above?:

The previous code was declaring constants inside a class, but this class did nothing and its only purpose was to group some constants.
The new code simply use constants, in the global scope.

What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit 9485353 into devel Sep 9, 2022
@rdwebdesign rdwebdesign deleted the use_constants branch September 9, 2022 17:26
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/cannot-see-dashboard-screens-after-recent-pi-hole-update/58039/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants