Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httponly = true to persistent login cookie #1875

Merged
merged 1 commit into from
Sep 11, 2021

Conversation

PromoFaux
Copy link
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

What does this PR aim to accomplish?:

Sets the httponly property of the persistentlogin cookie to true, discussed : #1447

… doesn't actually seem to do anything... (but not removing it just in case

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux added this to the v5.6 milestone Sep 11, 2021
@PromoFaux PromoFaux requested a review from a team September 11, 2021 18:38
@PromoFaux
Copy link
Member Author

Before:

image

After:

image

@DL6ER DL6ER merged commit c5cfb29 into release/v5.6 Sep 11, 2021
@DL6ER DL6ER deleted the tweak/http-only-cookies branch September 11, 2021 18:42
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants