Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix require func.php #1855

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Fix require func.php #1855

merged 1 commit into from
Aug 1, 2021

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 1, 2021

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

Fix errors reported on discourse (https://discourse.pi-hole.net/t/tools-network-errors-in-beta/48611) due to 03920e3. The commit added require("scripts/pi-hole/php/func.php"); to api_db.php but it was already required by the also included scripts/pi-hole/php/auth.php

How does this PR accomplish the above?:

Replace require with require_once

Signed-off-by: yubiuser <ckoenig@posteo.de>
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/tools-network-errors-in-beta/48611/12

@DL6ER DL6ER merged commit 3140bb5 into pi-hole:release/v5.6 Aug 1, 2021
@yubiuser yubiuser deleted the fix_func.php branch August 9, 2021 07:49
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants