Do not apply IDNA conversion to RegEx domains (#2336)

pi-hole · Sep 8, 2022 · c958cc8 · c958cc8
2 parents dbd87d8 + e5ce534
commit c958cc8
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/scripts/pi-hole/php/groups.php b/scripts/pi-hole/php/groups.php
@@ -596,14 +596,15 @@ function verify_ID_array($arr)
                 continue;
             }
 
-            $input = $domain;
-            // Convert domain name to IDNA ASCII form for international domains
-            // Skip this for the root zone `.`
-            if ($domain != '.') {
-                $domain = convertUnicodeToIDNA($domain);
-            }
             if ($_POST['type'] != '2' && $_POST['type'] != '3') {
-                // If not adding a RegEx, we convert the domain lower case and check whether it is valid
+                // If not adding a RegEx....
+                $input = $domain;
+                // Convert domain name to IDNA ASCII form for international domains
+                // Skip this for the root zone `.`
+                if ($domain != '.') {
+                    $domain = convertUnicodeToIDNA($domain);
+                }
+                // convert the domain lower case and check whether it is valid
                 $domain = strtolower($domain);
                 $msg = '';
                 if (!validDomain($domain, $msg)) {