Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tzdata package so that users can define their own timezone at runtime #1394

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add tzdata package so that users can define their own timezone at runtime #1394

merged 1 commit into from
Jul 24, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Assuming the time zone is set in the environment with:

environment:
     TZ: 'Europe/London'

Before:

pihole:/# date
Sun Jul 23 20:17:53 UTC 2023

After:

pihole:/# date
Sun Jul 23 21:17:29 BST 2023

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux PromoFaux requested a review from a team July 23, 2023 20:19
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PromoFaux
Add tzdata package so that users can define their own timezone at run…
93826e2 
…time

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@github-actions
Copy link

Conflicts have been resolved.

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux merged commit a317129 into development-v6 Jul 24, 2023
19 checks passed
@PromoFaux PromoFaux deleted the v6/tzdata branch July 24, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdwebdesign rdwebdesign rdwebdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PromoFaux @rdwebdesign