Don't declare VIRTUAL_HOST as an empty string in Dockerfile #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cally create this file on container start. This gets rid of what was probably a hack to have the VIRTUAL_HOST declared as an empty string in the Dockerfile (lighttpd would not start if env.VIRTUAL_HOST was not set Signed-off-by: Adam Warner <me@adamwarner.co.uk>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Possibly causes issues with other containers (though, personally I do not see how - but then, I'm not a Docker expert), see nginx-proxy/nginx-proxy#1674 (reply in thread) for a discussion that may make more sense to you, dear reader.
This change set keeps things functionally the same as they were before - just syntactically different.
15-pihole-admin-redirect-docker.confnow created on the fly rather than forcing the env var to exist system-wide (if it doesn't exist, lighttpd falls over)By submitting this pull request, I confirm the following:
git rebase)