New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the PHP_ENV_CONFIG variable from the Dockerfile #1281

Merged

PromoFaux merged 1 commit into dev from remove-PHP_ENV_CONFIG_var

Jan 18, 2023

Member

PromoFaux commented Jan 18, 2023

What does this PR aim to accomplish?:

The default value of this env var was changed in #1269, however on closer inspection, it seems that there is no current reason for it to be one...

I think this probably explains the issues we are seeing #1275

Clued in by this reddit comment

By submitting this pull request, I confirm the following:

I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
I have commented my proposed changes within the code and I have tested my changes.
I am willing to help maintain this change if there are issues with it later.
It is compatible with the EUPL 1.2 license
I have squashed any insignificant commits. (git rebase)

I have read the above and my PR is ready for review. Check this box to confirm


          I don't know why PHP_ENV_CONFIG is an environment variable. We don't …

61bd3c7

…need it to be

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

sonarcloud bot commented Jan 18, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

PromoFaux merged commit b96b257 into dev

PromoFaux deleted the remove-PHP_ENV_CONFIG_var branch

January 18, 2023 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet