Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some variables so that they cannot be overridden by users #1212

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Title - some users can face confusion when upgrading to the latest container, as their GUI management programme retains the old values of certain variables. Eliminate the problem by making them hardcoded. They don't need to be set at runtime, anyway.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux requested a review from a team September 19, 2022 21:04
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PromoFaux PromoFaux changed the title Change some variables to not be user-overridable Change some variables so that they cannot be overridden by users Sep 20, 2022
@PromoFaux PromoFaux merged commit 71d77b5 into dev Sep 20, 2022
@PromoFaux PromoFaux deleted the refactor-some-more branch September 20, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants