Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running locally derive port from FTL itself #362

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Aug 2, 2023

What does this PR aim to accomplish?:

If n $URL is supplied, we assume we run PADD on the same host as FTL so we can use FTL to tell us the port we need to use. Saves users from using --port PORT locally.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested review from PromoFaux and a team August 2, 2023 19:35
Signed-off-by: Christian König <ckoenig@posteo.de>
padd.sh Show resolved Hide resolved
padd.sh Outdated Show resolved Hide resolved
Signed-off-by: Christian König <ckoenig@posteo.de>
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@yubiuser yubiuser merged commit c6e8f07 into PADD_FTLv6 Aug 2, 2023
5 checks passed
@yubiuser yubiuser deleted the set_port branch August 2, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants