Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 314 📝 update 'how to run PADD in docker container' #315

Merged
merged 3 commits into from
Jan 15, 2023

Conversation

thomasmerz
Copy link
Sponsor Contributor

@thomasmerz thomasmerz commented Dec 27, 2022

What does this PR aim to accomplish?:

This PR fixes issue #314 by describing how to run PADD in a docker container.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

README.md Outdated Show resolved Hide resolved
thomasmerz and others added 2 commits December 27, 2022 12:43
Co-authored-by: Adam Warner <github@adamwarner.co.uk>
Signed-off-by: thomasmerz <thomasmerz@users.noreply.github.com>
@yubiuser yubiuser linked an issue Dec 27, 2022 that may be closed by this pull request
@PromoFaux PromoFaux merged commit 26f6c9a into pi-hole:master Jan 15, 2023
@thomasmerz thomasmerz deleted the issue_314 branch January 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README file needs update
3 participants