Fix spurious "resource limit exceeded" messages (v5 backport) #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync master back into development
Replies from upstream with a REFUSED rcode can result in log messages stating that a resource limit has been exceeded, which is not the case. Thanks to Dominik Derigs and the Pi-hole project for spotting this. Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
|
Confirmed on Discourse:
|
rdwebdesign
approved these changes
Feb 20, 2024
dschaper
approved these changes
Feb 20, 2024
truecharts-admin
referenced
this pull request
in truecharts/charts
Mar 4, 2024
…56 by renovate (#18853) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pihole/pihole](https://togithub.com/pi-hole/docker-pi-hole) | patch | `2024.02.0` -> `2024.02.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pi-hole/docker-pi-hole (pihole/pihole)</summary> ### [`v2024.02.2`](https://togithub.com/pi-hole/docker-pi-hole/releases/tag/2024.02.2) [Compare Source](https://togithub.com/pi-hole/docker-pi-hole/compare/2024.02.1...2024.02.2) Jumped the gun a little with the last tag - didn't realise there were changes ready to go! Should fix: [https://github.com/pi-hole/docker-pi-hole/issues/1543](https://togithub.com/pi-hole/docker-pi-hole/issues/1543) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed - Enhance theme validation by [@​ADawidowski](https://togithub.com/ADawidowski) in [https://github.com/pi-hole/docker-pi-hole/pull/1500](https://togithub.com/pi-hole/docker-pi-hole/pull/1500) #### New Contributors - [@​ADawidowski](https://togithub.com/ADawidowski) made their first contribution in [https://github.com/pi-hole/docker-pi-hole/pull/1500](https://togithub.com/pi-hole/docker-pi-hole/pull/1500) **Full Changelog**: pi-hole/docker-pi-hole@2024.02.0...2024.02.2 ### [`v2024.02.1`](https://togithub.com/pi-hole/docker-pi-hole/releases/tag/2024.02.1) [Compare Source](https://togithub.com/pi-hole/docker-pi-hole/compare/2024.02.0...2024.02.1) Nothing Docker-specific this time around, tagging to include FTL v5.25.1 <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed (FTL) - Fix spurious "resource limit exceeded" messages (v5 backport) by [@​DL6ER](https://togithub.com/DL6ER) in [https://github.com/pi-hole/FTL/pull/1893](https://togithub.com/pi-hole/FTL/pull/1893) **Full Changelog**: pi-hole/FTL@v5.25...v5.25.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Backports #1892 to FTL v5.25 - aiming straight for a bugfix release.
Related issue or feature (if applicable): https://discourse.pi-hole.net/t/pihole-unbound-dnsmasq-validation-failed-resource-limit-exeeded/68388
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.