Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capabilities check for feature dhcp-discover #1561

Merged
merged 1 commit into from
May 20, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 20, 2023

What does this implement/fix?

Add capabilities check for feature pihole-FTL dhcp-discover in the same way we already have it for pihole-FTL arp-scan

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…lready have it for arp-scan

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added PR: Approval Required Open Pull Request, needs approval Capabiltities labels May 20, 2023
@DL6ER DL6ER requested a review from a team May 20, 2023 12:42
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could tweak the failure output a bit (different PR): e.g. which interface failed? I guess it's my docker interfaces and the wireguard interface.

Scanning all your interfaces for DHCP servers
Timeout: 10 seconds

WARN: Could not sendto() in send_dhcp_discover() (/__w/FTL/FTL/src/tools/dhcp-discover.c:235): Operation not permitted
WARN: Could not sendto() in send_dhcp_discover() (/__w/FTL/FTL/src/tools/dhcp-discover.c:235): Operation not permitted
* Received 548 bytes from eno1:10.0.1.1

@yubiuser
Copy link
Member

Maybe it's only wireguard.

DHCP packets received on interface eno1: 2
DHCP packets received on interface lo: 0
DHCP packets received on interface br-8f8a772de3d9: 0
DHCP packets received on interface docker0: 0
DHCP packets received on interface veth57f8f05: 0
DHCP packets received on interface vethee977de: 0
DHCP packets received on interface vetha384b51: 0
DHCP packets received on interface br-a638779dc7e3: 0

@DL6ER DL6ER merged commit 9b45d5c into development May 20, 2023
@DL6ER DL6ER deleted the tweak/dhcp-discover-capabilities branch May 20, 2023 15:37
This was referenced May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Capabiltities PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants