Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable declaration #1546

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Fix variable declaration #1546

merged 2 commits into from
Mar 27, 2023

Conversation

Smarre
Copy link
Contributor

@Smarre Smarre commented Mar 24, 2023

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

Fixes build on at least current OpenSUSE Tumbleweed.

How does this PR accomplish the above?:

By fixing certain wrongly declared functions and variables to be declared correctly.

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Fixes build on OpenSUSE Tumbleweed.

Signed-off-by: Samu Voutilainen <smar@smar.fi>
Signed-off-by: Samu Voutilainen <smar@smar.fi>
DL6ER
DL6ER previously approved these changes Mar 26, 2023
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DL6ER DL6ER changed the title Build fixes Fix variable declaration Mar 26, 2023
@DL6ER
Copy link
Member

DL6ER commented Mar 26, 2023

@Smarre
Copy link
Contributor Author

Smarre commented Mar 27, 2023

@Smarre could you sign your commits?

Sorry, looks like I forgot to push the signed versions.

@DL6ER DL6ER merged commit 6a1de9f into pi-hole:development Mar 27, 2023
@DL6ER DL6ER mentioned this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants