Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repo specific issue and pull request template #1466

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 4, 2022

Removes the repo specific issue and PR template. The templates should default now to the org's default templates located at https://github.com/pi-hole/.github.

Some requirements from the FTL repo PR template have been moved to the org's PR template by pi-hole/.github#22

This template was created based on the work of udemy-dl.

@yubiuser yubiuser requested a review from a team November 4, 2022 16:39
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Nov 4, 2022
@yubiuser yubiuser requested a review from DL6ER November 4, 2022 19:08
DL6ER
DL6ER previously approved these changes Nov 6, 2022
@DL6ER
Copy link
Member

DL6ER commented Nov 6, 2022

@yubiuser

The base branch requires all commits to be signed.

Do you want to do this or shall we overwrite the requirement for you?

@yubiuser
Copy link
Member Author

yubiuser commented Nov 6, 2022

Haha, it's because the new template is not yet rolled out ;-)

I'll sign and force push

Signed-off-by: Christian König <ckoenig@posteo.de>
@DL6ER DL6ER merged commit 17ce7ec into development Nov 6, 2022
@DL6ER DL6ER deleted the templates branch November 6, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants