Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex extension: Specify reply type #1159

Merged
merged 4 commits into from
Sep 11, 2021
Merged

Regex extension: Specify reply type #1159

merged 4 commits into from
Sep 11, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 10, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Implements a feature request from Discourse:

Regex extension that allows you to specify the reply that is sent to matching queries. This is useful when some of your devices do not support the blocking mode you like to use for the rest of the devices in your network.

Example syntax:

regex;reply=NODATA

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER added this to the v5.9 milestone Sep 10, 2021
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/custom-redirects/37272/37

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/regex-engine-improvements/46304/36

@DL6ER
Copy link
Member Author

DL6ER commented Sep 10, 2021

This feature has been independtly tested by @jpgpi250: https://discourse.pi-hole.net/t/regex-engine-improvements/46304/35?u=dl6er

@DL6ER DL6ER marked this pull request as draft September 11, 2021 06:36
…e.g., "someregex;reply=1.2.3.4;reply=fe80::1234"

Signed-off-by: DL6ER <dl6er@dl6er.de>
…4", and "reply=1.2.3.4;reply=fe80:1234"

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER marked this pull request as ready for review September 11, 2021 14:24
@DL6ER
Copy link
Member Author

DL6ER commented Sep 11, 2021

Has been tested here as well: https://discourse.pi-hole.net/t/custom-redirects/37272/40

@DL6ER DL6ER merged commit 198fec7 into release/v5.9 Sep 11, 2021
@DL6ER DL6ER deleted the new/regex_replytype branch September 11, 2021 16:55
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/custom-redirects/37272/42

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/custom-redirects/37272/46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants