Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning messages for defect hwclocks #1136

Merged
merged 1 commit into from
May 12, 2021

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented May 11, 2021

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Improve warning message when importing queries from the future (a typical problem of systems starting at 1970-01-01 on every boot). Also, show the warning only once instead of flooding the log file.

…ical problem of systems starting at 1970-01-01 on every boot). Also, show the warning only once instead of flooding the log file.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team May 11, 2021 09:14
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/getovertimeid-is-too-large-warning/46824/19

@DL6ER DL6ER added the PR: Approval Required Open Pull Request, needs approval label May 11, 2021
@dschaper dschaper added PR: Approved Open Pull Request, Approved by required number of reviewers and removed PR: Approval Required Open Pull Request, needs approval labels May 12, 2021
@dschaper
Copy link
Member

Housekeeping:

The committer email address is not verified.

@DL6ER
Copy link
Member Author

DL6ER commented May 12, 2021

Thanks. This is a Github bug. I contacted their service already about it but they seem unwilling to help. The issue is that some emails from Github are rejected by the junk filter and, as a result, Github unverifies my email immediately.

Screenshot from 2021-05-12 08-43-27
Screenshot from 2021-05-12 08-46-04

I do not see any notification about it and the "fix" is to simply verify the mail address again. I did that at least 50 times already but it happens again ever 10 days to three months. I'm happy if someone points me to it when I forget about it. It is always (and has always been) the same email address...

@DL6ER DL6ER merged commit 5a8169f into development May 12, 2021
@DL6ER DL6ER deleted the tweak/incorrect_hwclock_warning branch May 12, 2021 09:59
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/49544/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Enhancement PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants