Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom function utils.path_exists_or_make_it() with core function os.makedirs() #345

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

merelvdthiel
Copy link
Contributor

@merelvdthiel merelvdthiel commented Nov 12, 2020

Closes #334

Proposed Changes

-Remove the function and the associated tests
-Replace the function call throughout the package

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • internal (no version update)
  • documentation (no version update)

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the Refactoring Improve nonfunctional attributes label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #345 (9376834) into master (b965b03) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   94.89%   94.88%   -0.02%     
==========================================
  Files           9        9              
  Lines         843      840       -3     
==========================================
- Hits          800      797       -3     
  Misses         43       43              
Impacted Files Coverage Δ
phys2bids/utils.py 98.52% <ø> (-0.07%) ⬇️
phys2bids/bids.py 98.05% <100.00%> (ø)
phys2bids/phys2bids.py 89.53% <100.00%> (ø)

@merelvdthiel merelvdthiel marked this pull request as ready for review November 12, 2020 23:16
@smoia smoia requested a review from 62442katieb November 12, 2020 23:16
Copy link
Contributor

@62442katieb 62442katieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is legit, can confirm.

@smoia
Copy link
Member

smoia commented Nov 12, 2020

Looks legit. @62442katieb want to do the honours of merging?

@62442katieb
Copy link
Contributor

Looks legit. @62442katieb want to do the honours of merging?

I would sincerely be honored.

@62442katieb 62442katieb merged commit 89e836b into physiopy:master Nov 12, 2020
@merelvdthiel merelvdthiel deleted the ref/makedir branch November 13, 2020 10:35
@smoia smoia changed the title Replace utils.path_exists_or_make_it() with os.makedirs() Replace custom function utils.path_exists_or_make_it() with core function os.makedirs() Nov 13, 2020
@smoia
Copy link
Member

smoia commented Nov 29, 2020

🚀 PR was released in 2.3.0 🚀

@smoia smoia added the released This issue/pull request has been released. label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Improve nonfunctional attributes released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace utils.path_exists_or_make_it() with os.makedirs()
3 participants