Improve code compliance to BIDS in BlueprintOputput #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoia
changed the title
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 7 7
Lines 568 568
=======================================
Hits 537 537
Misses 31 31
|
smoia
added
the
Minormod
rmarkello
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
This seems fine to me !
Looking at this made me think that we should potentially discuss revisiting the BlueprintOutput object to use some special dunder features (like __index__ and __getitem__) to make it a bit easier to use, but I'll make an issue with my thoughts on that !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184 better than #187
Proposed Changes
timeseriesattribute of theBlueprintOuputduring export, the object is initialised BIDS compliant.