Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind users to note whether a clade definition specifies a crown clade in the verbatim definition #71

Closed
gaurav opened this issue Jun 27, 2018 · 5 comments · Fixed by #297
Labels
difficulty: easy Should be easy to do (1-2 days) programming only No discussion necessary; just pure programming needed
Milestone

Comments

@gaurav
Copy link
Member

gaurav commented Jun 27, 2018

In an embargoed curated example, we've found a clade definition whose verbatim definition starts with "The largest crown clade containing ...", even though the clade definition points to the total or pan group. Readers are therefore expected to resolve the clade definition, and then exclude the stem groups that would otherwise be included, in order to obtain the crown group.

The Curation Tool doesn't currently have a way of indicating that a phyloreference should be restricted to the crown clade, i.e. the reasoner should try to exclude stem groups automatically after resolving the clade definition. This property will require additional annotation of the phylogeny to indicate which terminal groups are extinct, so this issue covers adding that annotation as well.

@ncellinese
Copy link

ncellinese commented Jun 27, 2018 via email

@gaurav
Copy link
Member Author

gaurav commented Jun 27, 2018

Nico and I just had an in-person discussion about this, and decided that this works better with an example. The actual example comes from clade Angiospermae. In the reference phylogeny, pan-Angiospermae includes four extinct lineages (Glossopterids, Pentoxylon, Bennettitales, Caytonia) and one extant lineage (Angiospermae). If the definition were simply "The largest clade containing ... but not ...", it would resolve to pan-Angiospermae. But since it is "The largest crown clade containing ... but not ...", we need to exclude the four extinct lineages so that we instead resolve to Angiospermae. If we have some way of annotating which terminal nodes are extinct in the phylogeny, we could exclude them after reasoning.

In addition, the clade definition of pan-Angiospermae is simply "the total clade of the crown clade Angiospermae". So, whatever mechanism we develop for excluding extinct lineages, we have to be able to subsequently ignore them if necessary. This would be easiest if carried out after reasoning, but we could also try to find ways to integrate this into the OWL restrictions we use.

@gaurav
Copy link
Member Author

gaurav commented Dec 15, 2021

The information that a phyloreference should be resolved as a crown clade should probably be included in the curator notes (as we do for the reference taxon information, #70), since this information is not used to construct the logical expressions in OWL in any way. Therefore, I propose that we explicitly note that crown clade status should be included in that field and then close this issue.

@hlapp
Copy link
Member

hlapp commented Dec 15, 2021

We should discuss but I think I agree. I.e., our main objective here should be to ensure this information is retained. Whether it is to be retained in a well-parseable and thus structured way is debatable. It's not called for by the Phyx format in its current published incarnation, nor is it needed or even only taken into account for the semantics.

@gaurav gaurav changed the title Property to indicate phyloreferences that should be resolved as a crown clade even if they point to a total clade Remind users to note whether a clade definition specifies a crown clade in the verbatim definition Dec 15, 2021
@gaurav
Copy link
Member Author

gaurav commented Dec 15, 2021

  • Add note to Klados to make it clear that information about clade resolution ("crown" etc.) should be included in the verbatim clade definition.

@gaurav gaurav added programming only No discussion necessary; just pure programming needed and removed discussion needed Discussion is needed before this issue can be closed labels Dec 15, 2021
gaurav added a commit that referenced this issue May 28, 2023
…text

When initially building the Klados user interface I added a lot of placeholder texts. This PR removes placeholders texts that are redundant (as per #218) or moves the non-redundant text into the field label. It does improve the placeholder for the clade definition to `e.g. 'The largest crown clade containing Canis lupus Linnaeus 1758 (Canidae) but not Felis silvestris Schreber 1777 (Felidae).'`, which should also close #71.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy Should be easy to do (1-2 days) programming only No discussion necessary; just pure programming needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants