Add optional chainId (anoma#487)

phy-chain · Dec 1, 2023 · 4d45378 · 4d45378
1 parent da03815
commit 4d45378
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/apps/extension/src/provider/Namada.ts b/apps/extension/src/provider/Namada.ts
@@ -25,14 +25,18 @@ export class Namada implements INamada {
     );
   }
 
-  public async accounts(): Promise<DerivedAccount[] | undefined> {
+  public async accounts(
+    _chainId?: string
+  ): Promise<DerivedAccount[] | undefined> {
     return await this.requester?.sendMessage(
       Ports.Background,
       new QueryAccountsMsg()
     );
   }
 
-  public async defaultAccount(): Promise<DerivedAccount | undefined> {
+  public async defaultAccount(
+    _chainId?: string
+  ): Promise<DerivedAccount | undefined> {
     return await this.requester?.sendMessage(
       Ports.Background,
       new QueryDefaultAccountMsg()

diff --git a/packages/integrations/src/Namada.ts b/packages/integrations/src/Namada.ts
@@ -37,14 +37,16 @@ export default class Namada implements Integration<Account, Signer> {
     await this._namada?.connect(chainId);
   }
 
-  public async accounts(): Promise<readonly Account[] | undefined> {
+  public async accounts(
+    chainId?: string
+  ): Promise<readonly Account[] | undefined> {
     const signer = this._namada?.getSigner();
-    return await signer?.accounts();
+    return await signer?.accounts(chainId);
   }
 
-  public async defaultAccount(): Promise<Account | undefined> {
+  public async defaultAccount(chainId?: string): Promise<Account | undefined> {
     const signer = this._namada?.getSigner();
-    return await signer?.defaultAccount();
+    return await signer?.defaultAccount(chainId);
   }
 
   public signer(): Signer | undefined {

diff --git a/packages/types/src/namada.ts b/packages/types/src/namada.ts
@@ -11,8 +11,8 @@ export type TxMsgProps = {
 
 export interface Namada {
   connect(chainId?: string): Promise<void>;
-  accounts(): Promise<DerivedAccount[] | undefined>;
-  defaultAccount(): Promise<DerivedAccount | undefined>;
+  accounts(chainId?: string): Promise<DerivedAccount[] | undefined>;
+  defaultAccount(chainId?: string): Promise<DerivedAccount | undefined>;
   balances(
     owner: string
   ): Promise<{ token: string; amount: string }[] | undefined>;

diff --git a/packages/types/src/signer.ts b/packages/types/src/signer.ts
@@ -11,8 +11,8 @@ import {
 } from "./tx";
 
 export interface Signer {
-  accounts: () => Promise<Account[] | undefined>;
-  defaultAccount: () => Promise<Account | undefined>;
+  accounts: (chainId?: string) => Promise<Account[] | undefined>;
+  defaultAccount: (chainId?: string) => Promise<Account | undefined>;
   submitBond(
     args: SubmitBondProps,
     txArgs: TxProps,