Extend exporter ACL policy #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the exporter to view details about a job which is relevant for the content of the `project/.../executions` endpoint. Without this permission the response never contains details about executions so all the exporter knows about is running executions but not what happened with the executions which makes it a bit pointless.
phsmith
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the exporter to view details about a job which is relevant for the content of the
project/.../executionsendpoint.Without this permission the response never contains details about executions so all the exporter knows about is running executions but not what happened with the executions which makes it a bit pointless.
I was using the policy that was added via #67 but all the dashboard showed for me was 0% success rate and every job was supposedly in running state. Turns out the exporter did not have permissions to get information about the executions once they were out of running. Maybe this is a new part of the ACLs, not sure. I am on rundeck 4.17