Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recentFilter for /executions/running endpoint #70

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

davidcpell
Copy link
Contributor

@davidcpell davidcpell commented May 31, 2023

#69 introduced made the execution API's recentFilter value configurable via RUNDECK_PROJECTS_EXECUTIONS_FILTER but this was only applied to the main /executions endpoint. This PR also uses the value in the /executions/running endpoint.

We discovered the endpoint doesn't accept this parameter, so we're now just removing it altogether.

@phsmith
Copy link
Owner

phsmith commented Jun 1, 2023

@davidcpell I have kept the /executions/running endpoint with recentFilter=1d because we can have long running jobs, so if this period is set too short some executions may be missed. Note that if no jobs are running, no results will be retrieved.

@davidcpell
Copy link
Contributor Author

@phsmith looking back at the documentation, it doesn't seem like the endpoint actually supports the recentFilter parameter: https://docs.rundeck.com/docs/api/rundeck-api.html#listing-running-executions

image

Thinking about it, it makes sense because I think I would expect the endpoint that lists running executions to list all currently-running executions regardless of when they started. If anything, this endpoint probably needs to be queried as frequently as possible/reasonable to get accurate data.

@phsmith
Copy link
Owner

phsmith commented Jun 1, 2023

Oh, man... You're absolutely right, sorry!
I can't even remember why I put the recentFilter there, maybe just copy and paste from the line above one. 🙃

Would you mind in removing this filter so I can approve and merge your PR?

@davidcpell
Copy link
Contributor Author

done! 5b9cb4a

@davidcpell davidcpell changed the title use project_executions_filter for /executions/running endpoint remove recentFilter for /executions/running endpoint Jun 1, 2023
@phsmith phsmith merged commit b8ea895 into phsmith:main Jun 1, 2023
@phsmith
Copy link
Owner

phsmith commented Jun 1, 2023

Awesome! Thanks for your contribution @davidcpell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants